Repository navigation
feat: add SahabatMobile provider - #7204
Open
sahabatmobile wants to merge 2 commits into
Open
sahabatmobile wants to merge 2 commits into
sahabatmobile wants to merge 2 commits into
Conversation
Contributor
Action items
|
Contributor
Action items
|
Contributor
## Action items
- **[high] [violation]** `providers/sahabatmobile/models/mimo-v2.5.toml:1` - **Check:** Non-lab hosts must use `base_model` and stay override-only. **Why:** SahabatMobile is a multi-model gateway, not the creator of MiMo / MiniMax / Qwen. Lab metadata already exists (`xiaomi/mimo-v2.5`, `minimax/MiniMax-M3`, `alibaba/qwen3.8-max`), but all three provider files are full standalone definitions with no `base_model`. That breaks the lab-vs-provider split and re-authors lab facts on the host. **Action:** Rewrite each file as `base_model = "…"` plus only provider deltas (`cost`, `reasoning_options`, and real host-specific overrides). Do not restate inherited name/dates/`open_weights`/`[limit]`/`[modalities]` unless this API truly differs.
- **[high] [violation]** `providers/sahabatmobile/models/mimo-v2.5.toml:3` - **Check:** `reasoning = true` requires host `reasoning_options` matching lab/same-surface peers. **Why:** All three models set `reasoning = true` with no `reasoning_options`. First-party/peers use: MiMo-V2.5 → `toggle`; MiniMax-M3 → `toggle`; Qwen3.8 Max → `toggle` + effort `low`/`medium`/`xhigh` + `budget_tokens`. Empty/`[]` is only valid when the host has no caller control. **Action:** Author `reasoning_options` per model from lab + peers for this OpenAI-compatible surface; every `toggle` needs a leading top-of-file wire-path comment.
- **[medium] [possible mistake]** `providers/sahabatmobile/models/mimo-v2.5.toml:6` - **Check:** Provider-authored facts must not contradict known lab metadata without evidence. **Why:** Inline values conflict with existing lab entries—e.g. MiMo `open_weights = false` (lab `true`), knowledge/release dates off lab (`2024-12` / `2026-04-22`), modalities drop audio/video; MiniMax drops video and shrinks output vs `512_000`; Qwen drops video/pdf vs lab modalities. **Action:** Prefer inheritance via `base_model`. Only keep local overrides that this host actually enforces, and cite host docs for any intentional deltas.
- **[low] [possible mistake]** `.pr-review/pull-request.json:3` - **Check:** Data-changing PRs should cite direct pricing/docs mapped to claims. **Why:** Body links general docs only; no source mapping for the published USD/MTok costs (`0.15`/`0.45`, `0.30`/`1.20`, `2.00`/`6.00`) or claimed limits. **Action:** Add first-party SahabatMobile pricing/model citations in the PR body (and a leading TOML comment if hand-authored) stating what each URL supports. |
Contributor
Action items
|
Contributor
Action items
|
Contributor
Action items
|
Contributor
Action items
|
Contributor
|
No actionable findings. |
Contributor
|
No actionable findings. |
Contributor
Action items
|
Contributor
Action items
|
Contributor
Action items
|
Contributor
Action items
|
…rved-model evidence
Contributor
|
No actionable findings. |
Collaborator
|
This branch no longer shares history with dev, so it can't be merged as is. Could you rebase onto current dev (or reopen from a fresh branch)? The content passed review. |
sahabatmobile
temporarily deployed
to
release
November 15, 2026 05:26 — with
GitHub Actions
Inactive
Author
|
Hi @rekram1-node, thanks for the review! Per your suggestion, I've re-opened this from a fresh branch: #13727 (#13727) Content is unchanged from this PR (provider entry + MiniMax-M3, mimo-v2.5, qwen3.8-max, logo), revalidated with |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SahabatMobile — Indonesian AI gateway (OpenAI-compatible, QRIS billing).
Initial 3 models: mimo-v2.5, MiniMax-M3, qwen3.8-max.
API
Pricing (USD per 1M tokens, SahabatMobile retail)
Source: https://www.sahabatmobile.com/dashboard/packages (accessed 2026-11-05)
Reasoning controls (relay passthrough, OpenAI-compatible surface)