Skip to content

feat: add SahabatMobile provider - #7204

Open
sahabatmobile wants to merge 2 commits into
anomalyco:devfrom
sahabatmobile:dev
Open

sahabatmobile wants to merge 2 commits into
anomalyco:devfrom
sahabatmobile:dev

Conversation

@sahabatmobile

@sahabatmobile sahabatmobile commented Sep 16, 2026 •

Copy link
Copy Markdown

Add SahabatMobile — Indonesian AI gateway (OpenAI-compatible, QRIS billing).

Initial 3 models: mimo-v2.5, MiniMax-M3, qwen3.8-max.

API

Pricing (USD per 1M tokens, SahabatMobile retail)
Source: https://www.sahabatmobile.com/dashboard/packages (accessed 2026-11-05)

  • mimo-v2.5: input 0.15 / output 0.45
  • MiniMax-M3: input 0.30 / output 1.20
  • qwen3.8-max: input 2.00 / output 6.00

Reasoning controls (relay passthrough, OpenAI-compatible surface)

@github-actions

Copy link
Copy Markdown
Contributor

Action items

  • [critical] [violation] providers/sahabatmobile/Desain tanpa judul(2).svg:1 - Check: New providers must ship a compliant logo.svg. Why: The file is not named logo.svg, has fixed width/height, and embeds a raster PNG with hardcoded colors instead of a currentColor vector. That blocks provider rendering and fails the logo checklist. Action: Replace it with providers/sahabatmobile/logo.svg using currentColor, no fixed size/hardcoded colors, preferably a square viewBox.
  • [critical] [violation] providers/sahabatmobile/models/mimo-v2.5.toml:1 - Check: Non-lab hosts must use base_model for nameable lab models. Why: SahabatMobile is a multi-model gateway; MiMo V2.5 is Xiaomi’s model and models/xiaomi/mimo-v2.5.toml already exists. A full inline definition is not allowed here. Action: Set base_model = "xiaomi/mimo-v2.5" and keep only provider-specific fields/real deltas (cost, reasoning_options, genuine limit/modality overrides).
  • [critical] [violation] providers/sahabatmobile/models/MiniMax-M3.toml:1 - Check: Non-lab hosts must use base_model for nameable lab models. Why: MiniMax-M3 is MiniMax’s model and models/minimax/MiniMax-M3.toml already exists; full inline gateway definitions violate override-only policy. Action: Set base_model = "minimax/MiniMax-M3" and author only provider-specific overrides.
  • [critical] [violation] providers/sahabatmobile/models/qwen3.8-max.toml:1 - Check: Non-lab hosts must use base_model for nameable lab models. Why: Qwen 3.8 Max is Alibaba’s model and models/alibaba/qwen3.8-max.toml already exists; full inline definition is not allowed. Action: Set base_model = "alibaba/qwen3.8-max" and keep only host-specific fields/real deltas.
  • [critical] [violation] providers/sahabatmobile/models/mimo-v2.5.toml:3 - Check: reasoning = true requires reasoning_options for this host. Why: All three models set reasoning = true with no options. For a relay, copy the lab/same-surface peer control set (e.g. Xiaomi/OpenRouter MiMo: toggle; MiniMax: toggle; Alibaba Qwen3.8 Max: toggle + effort/budget as this API actually exposes), not invented L/M/H or blank uncertainty. Action: Add reasoning_options on each model for SahabatMobile’s OpenAI-compatible wire surface, with a leading top-of-file toggle wire comment when using toggle.
  • [high] [possible mistake] providers/sahabatmobile/models/mimo-v2.5.toml:9 - Check: Provider facts must not contradict established lab metadata without evidence. Why: Inline values conflict with models/xiaomi/mimo-v2.5 (e.g. open_weights = false vs lab true, knowledge/dates, modalities drop audio/video). Same pattern on MiniMax-M3 (open_weights, modalities, output limit) and Qwen (modalities drop video/pdf). Action: After switching to base_model, drop restated identical fields; only override real host deltas and cite docs/pricing for material cost/limit changes.

@github-actions

Copy link
Copy Markdown
Contributor

Action items

  • [critical] [violation] providers/sahabatmobile/ - Check: New provider must ship a compliant logo.svg. Why: The only logo candidate was deleted; the final tree has no providers/sahabatmobile/logo.svg. The removed file also used fixed width/height, embedded raster data, and non-currentColor styling. Action: Add providers/sahabatmobile/logo.svg using currentColor, no fixed size or hardcoded colors, preferably a square viewBox.
  • [critical] [violation] providers/sahabatmobile/models/mimo-v2.5.toml:1 - Check: Non-lab hosts must use base_model and stay override-only. Why: SahabatMobile is a multi-model gateway, not Xiaomi; lab metadata already exists at models/xiaomi/mimo-v2.5.toml. The file fully restates lab fields and contradicts the lab (e.g. open_weights = false vs lab true, knowledge/release dates, modalities, limits). Action: Set base_model = "xiaomi/mimo-v2.5" and keep only host-specific fields/deltas (cost, reasoning_options, real limit/modality overrides if this API differs).
  • [critical] [violation] providers/sahabatmobile/models/MiniMax-M3.toml:1 - Check: Non-lab hosts must use base_model and stay override-only. Why: MiniMax-M3 is a MiniMax lab model (models/minimax/MiniMax-M3.toml); this gateway file is a full inline copy with incorrect lab facts (open_weights = false, knowledge/release dates, modalities without video, much smaller output limit). Action: Set base_model = "minimax/MiniMax-M3" and author only provider cost/reasoning and genuine overrides.
  • [critical] [violation] providers/sahabatmobile/models/qwen3.8-max.toml:1 - Check: Non-lab hosts must use base_model and stay override-only. Why: Qwen3.8 Max is an Alibaba lab model (models/alibaba/qwen3.8-max.toml); the file fully inlines and drops lab modalities (video, pdf) while restating unchanged capabilities. Action: Set base_model = "alibaba/qwen3.8-max" and keep only host-specific fields/deltas.
  • [high] [violation] providers/sahabatmobile/models/mimo-v2.5.toml:3 - Check: reasoning = true requires reasoning_options for this host. Why: All three models set reasoning = true with no reasoning_options. For this relay, baseline from lab/peers is not optional empty-from-uncertainty: Xiaomi MiMo V2.5 lab uses toggle; MiniMax-M3 lab/peers use toggle; Qwen3.8 Max peers use toggle + effort (+ budget when exposed). Action: Add host-accurate reasoning_options (with leading wire-path comments for any toggle), matching lab + same-surface peers that this API actually forwards—not invented L/M/H and not [] unless the host truly exposes no control.
  • [low] [possible mistake] providers/sahabatmobile/models/*.toml ([cost]) - Check: Material pricing should cite first-party evidence. Why: PR body links docs only; costs (e.g. MiniMax 0.30/1.20 matching lab list, Qwen 2.00/6.00 matching lab list, MiMo 0.15/0.45 near lab 0.14/0.28) cannot be confirmed as SahabatMobile’s published USD/MTok rates. Action: Cite SahabatMobile pricing (or conversion rate/date if non-USD) in the PR body or a leading TOML comment, mapped to each model’s cost.

@github-actions

Copy link
Copy Markdown
Contributor
## Action items
- **[high] [violation]** `providers/sahabatmobile/models/mimo-v2.5.toml:1` - **Check:** Non-lab hosts must use `base_model` and stay override-only. **Why:** SahabatMobile is a multi-model gateway, not the creator of MiMo / MiniMax / Qwen. Lab metadata already exists (`xiaomi/mimo-v2.5`, `minimax/MiniMax-M3`, `alibaba/qwen3.8-max`), but all three provider files are full standalone definitions with no `base_model`. That breaks the lab-vs-provider split and re-authors lab facts on the host. **Action:** Rewrite each file as `base_model = "…"` plus only provider deltas (`cost`, `reasoning_options`, and real host-specific overrides). Do not restate inherited name/dates/`open_weights`/`[limit]`/`[modalities]` unless this API truly differs.
- **[high] [violation]** `providers/sahabatmobile/models/mimo-v2.5.toml:3` - **Check:** `reasoning = true` requires host `reasoning_options` matching lab/same-surface peers. **Why:** All three models set `reasoning = true` with no `reasoning_options`. First-party/peers use: MiMo-V2.5 → `toggle`; MiniMax-M3 → `toggle`; Qwen3.8 Max → `toggle` + effort `low`/`medium`/`xhigh` + `budget_tokens`. Empty/`[]` is only valid when the host has no caller control. **Action:** Author `reasoning_options` per model from lab + peers for this OpenAI-compatible surface; every `toggle` needs a leading top-of-file wire-path comment.
- **[medium] [possible mistake]** `providers/sahabatmobile/models/mimo-v2.5.toml:6` - **Check:** Provider-authored facts must not contradict known lab metadata without evidence. **Why:** Inline values conflict with existing lab entries—e.g. MiMo `open_weights = false` (lab `true`), knowledge/release dates off lab (`2024-12` / `2026-04-22`), modalities drop audio/video; MiniMax drops video and shrinks output vs `512_000`; Qwen drops video/pdf vs lab modalities. **Action:** Prefer inheritance via `base_model`. Only keep local overrides that this host actually enforces, and cite host docs for any intentional deltas.
- **[low] [possible mistake]** `.pr-review/pull-request.json:3` - **Check:** Data-changing PRs should cite direct pricing/docs mapped to claims. **Why:** Body links general docs only; no source mapping for the published USD/MTok costs (`0.15`/`0.45`, `0.30`/`1.20`, `2.00`/`6.00`) or claimed limits. **Action:** Add first-party SahabatMobile pricing/model citations in the PR body (and a leading TOML comment if hand-authored) stating what each URL supports.

@github-actions

Copy link
Copy Markdown
Contributor

Action items

  • [critical] [violation] providers/sahabatmobile/models/MiniMax-M3.toml:1 - Check: Non-lab hosts must use base_model and stay override-only. Why: SahabatMobile is a multi-model gateway, not MiniMax; lab metadata already exists at minimax/MiniMax-M3. This file is a full inline third-party definition (no base_model), which is a merge blocker. Action: Set base_model = "minimax/MiniMax-M3" and keep only host-specific fields (cost, reasoning_options, real deltas).
  • [critical] [violation] providers/sahabatmobile/models/qwen3.8-max.toml:1 - Check: Non-lab hosts must use base_model and stay override-only. Why: This is Alibaba’s Qwen3.8 Max (models/alibaba/qwen3.8-max.toml exists). Full inline definition on a gateway is forbidden. Action: Set base_model = "alibaba/qwen3.8-max" and keep only provider-specific overrides.
  • [critical] [violation] providers/sahabatmobile/models/mimo-v2.5.toml:1 - Check: After base_model, provider files must not restate identical or incorrect lab fields. Why: With base_model = "xiaomi/mimo-v2.5", the file still copies name/attachment/tool_call/temperature/knowledge/release_date/open_weights/[limit]/[modalities] and invents values that contradict the lab (e.g. open_weights = false vs lab true, knowledge = "2025-08" vs "2024-12", release_date = "2025-08-01" vs "2026-04-22", modalities drop audio/video, limits differ). Duplicate [cost] blocks are also present. Action: Strip to override-only (cost, reasoning_options, and only verified deltas); remove the duplicate [cost] table.
  • [high] [violation] providers/sahabatmobile/models/MiniMax-M3.toml:3 - Check: reasoning = true requires reasoning_options for this host. Why: MiniMax-M3 is a reasoner; lab/peers use toggle on the OpenAI-compatible path. Missing options is a blocker. Action: Add reasoning_options matching lab/same-surface peers (typically [{ type = "toggle" }]) plus a leading wire-path comment for the toggle.
  • [high] [violation] providers/sahabatmobile/models/qwen3.8-max.toml:3 - Check: reasoning = true requires host-accurate reasoning_options. Why: Alibaba first-party and solid relays expose toggle + effort low/medium/xhigh (+ optional budget_tokens). This file has none. Action: Author options from lab/peers for this OpenAI-compatible surface (not invented L/M/H-only), with a leading toggle wire comment.
  • [high] [violation] providers/sahabatmobile/models/mimo-v2.5.toml:13 - Check: Every toggle needs a leading top-of-file wire comment. Why: [[reasoning_options]] type = "toggle" is present with no documented request field; AGENTS.md requires the exact wire path above the first key. Action: Add a leading comment naming the toggle field this host accepts (or drop toggle if the API has no on/off control and document [] only with affirmative evidence).
  • [high] [violation] providers/sahabatmobile/logo.svg:2 - Check: New providers need a valid compliant logo.svg. Why: The SVG opens a root element and path but never closes </svg>, so the asset is malformed. Action: Ship a complete SVG using currentColor, no fixed width/height/hardcoded colors, preferably square viewBox.
  • [medium] [violation] providers/sahabatmobile/models/MiniMax-M3.toml:1 - Check: Resolved provider models must have description (and other required fields) via base or local. Why: The inline MiniMax and Qwen files omit description; without base_model they cannot inherit it. Action: Fix via base_model inheritance (preferred) so required lab fields resolve.
  • [low] [possible mistake] providers/sahabatmobile/models/mimo-v2.5.toml:18 - Check: Material cost/limit claims should cite provider pricing or docs. Why: PR body only links general docs; costs (0.15/0.45, 0.30/1.20, 2.00/6.00) and 1M-context claims are unmapped to sources. Action: In the PR body (or a leading TOML comment), cite first-party pricing/model pages and state what each URL supports.

@github-actions

Copy link
Copy Markdown
Contributor

Action items

  • [critical] [violation] providers/sahabatmobile/models/MiniMax-M3.toml:1 - Check: Third-party hosts must use base_model (override-only). Why: SahabatMobile is a multi-model gateway, not MiniMax; the lab entry minimax/MiniMax-M3 already exists, but this file is a full standalone definition (no base_model), restates lab fields, and omits description. Action: Set base_model = "minimax/MiniMax-M3" and keep only host-specific fields (cost, reasoning_options, and real deltas).
  • [critical] [violation] providers/sahabatmobile/models/qwen3.8-max.toml:1 - Check: Third-party hosts must use base_model (override-only). Why: This is Alibaba’s Qwen model; models/alibaba/qwen3.8-max.toml exists, but the provider file is a full inline definition without base_model/description. Action: Set base_model = "alibaba/qwen3.8-max" and keep only provider-specific fields and genuine overrides.
  • [critical] [violation] providers/sahabatmobile/models/MiniMax-M3.toml:3 - Check: reasoning = true requires reasoning_options. Why: Model is marked reasoning with no options; first-party/peers use toggle for MiniMax-M3. Action: Add host-accurate reasoning_options (baseline: lab/peers toggle) plus a leading wire-path comment if using toggle.
  • [critical] [violation] providers/sahabatmobile/models/qwen3.8-max.toml:3 - Check: reasoning = true requires reasoning_options. Why: No options authored; lab/same-surface peers expose toggle + effort (low/medium/xhigh) and often budget_tokens, not a blank control surface. Action: Author options matching this host’s API from lab/peer baseline (do not invent unrelated L/M/H or leave controls out from uncertainty).
  • [high] [violation] providers/sahabatmobile/models/mimo-v2.5.toml:7 - Check: After base_model, only real deltas — no contradictory restated metadata. Why: release_date = "2025-08-01", last_updated = "2026-09-01", and open_weights = false conflict with models/xiaomi/mimo-v2.5 (2026-04-22, open_weights = true). Action: Drop those keys unless this host truly differs; open-weights should inherit true.
  • [high] [violation] providers/sahabatmobile/models/mimo-v2.5.toml:12 - Check: Every toggle needs a leading top-of-file wire comment. Why: [[reasoning_options]] type = "toggle" has no documented request field path. Action: Add a leading comment with the exact SahabatMobile wire syntax (e.g. the field this API accepts to enable/disable thinking).
  • [high] [violation] providers/sahabatmobile/logo.svg:1 - Check: New provider logo.svg must be a valid, compliant SVG. Why: File is truncated — opens <svg> and a <path> but never closes </svg>, so the asset is incomplete. Action: Finish a valid SVG using currentColor, no fixed size/hardcoded colors, preferably square viewBox.
  • [medium] [possible mistake] providers/sahabatmobile/models/mimo-v2.5.toml:15 - Check: Limit/modality overrides must reflect the host, not shrink lab capability by accident. Why: Overrides cut output to 65536 (lab 131_072) and drop audio/video inputs present on the lab model; MiniMax/Qwen files similarly understate lab limits/modalities. Action: Verify against SahabatMobile docs/API and either match the host or remove incorrect overrides so lab values inherit.
  • [low] [possible mistake] providers/sahabatmobile/models/mimo-v2.5.toml:4 - Check: Data changes should cite pricing evidence. Why: PR body links general docs only; costs (0.15/0.45, 0.30/1.20, 2.00/6.00) lack mapped pricing citations. Action: Cite first-party pricing (or conversion note) for each model’s USD/MTok rates.

@github-actions

Copy link
Copy Markdown
Contributor

Action items

  • [high] [violation] providers/sahabatmobile/logo.svg:1 - Check: New providers require a valid, compliant logo.svg (currentColor, no fixed size/hardcoded color, preferably square viewBox). Why: The SVG opens but never closes (</svg> is missing), so the logo is malformed and not a valid standalone SVG. Action: Complete the SVG (close the root element) and keep currentColor with no fixed width/height or hardcoded colors.
  • [high] [violation] providers/sahabatmobile/models/mimo-v2.5.toml:2 - Check: Every toggle must document the exact host wire path; relays should match lab/peer controls, not invent another lab’s field. Why: The comment claims enable_thinking true|false “proxied to upstream lab API,” but first-party Xiaomi MiMo uses thinking.type = enabled|disabled (see providers/xiaomi/provider.toml), not Alibaba’s enable_thinking. A wrong wire path misleads callers. Action: Verify SahabatMobile’s real request field for this model; set the leading comment (and option shape) to that path—e.g. thinking.type if it faithfully proxies Xiaomi—or cite host docs if the gateway truly renames the control.
  • [high] [violation] providers/sahabatmobile/models/MiniMax-M3.toml:2 - Check: Toggle wire comments must match this host’s API and the underlying lab/same-surface peers. Why: The file also claims enable_thinking true|false proxied upstream, but MiniMax OpenAI-compatible peers document thinking.type (enabled/adaptive/disabled), not enable_thinking. Action: Confirm the SahabatMobile request field for MiniMax-M3 and correct the leading toggle comment (and controls if needed) to the real wire path.

@github-actions

Copy link
Copy Markdown
Contributor

Action items

  • [high] [violation] providers/sahabatmobile/models/mimo-v2.5.toml:2 - Check: Toggle wire comment must document this host’s exact request field (lab/peer baseline for MiMo V2.5). Why: Comment claims enable_thinking true|false “proxied to upstream lab API,” but first-party Xiaomi documents thinking.type = "enabled"|"disabled" (see providers/xiaomi/provider.toml), not enable_thinking. Clients will send the wrong control. Action: Set the leading comment to this host’s real wire path (passthrough thinking.type if proxying Xiaomi, or the SahabatMobile-specific field if the gateway normalizes). Do not claim lab passthrough with a Qwen-style field.
  • [high] [violation] providers/sahabatmobile/models/MiniMax-M3.toml:2 - Check: Toggle wire comment must match MiniMax’s control surface (lab/peer baseline). Why: Same generic enable_thinking comment is used, but MiniMax OpenAI-compatible peers document thinking.type / $.thinking.type (enabled|disabled|adaptive), not enable_thinking. Action: Replace the comment with the actual SahabatMobile/MiniMax wire path (or drop toggle only if this host truly has no on/off control—and then justify [] with evidence).
  • [low] [possible mistake] providers/sahabatmobile/models/mimo-v2.5.toml:8 - Check: Material cost claims should map to first-party pricing evidence. Why: PR body only links general docs; MiMo cost (0.15/0.45) differs from lab (0.14/0.28) with no per-model citation. Action: In the PR body (or leading TOML comments), cite the SahabatMobile pricing page/section for each model’s USD/MTok rates.

@github-actions

Copy link
Copy Markdown
Contributor

No actionable findings.

@github-actions github-actions Bot added the reviewer: ready Automated review found no actionable items label Sep 16, 2026
@github-actions github-actions Bot removed the reviewer: ready Automated review found no actionable items label Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

No actionable findings.

@github-actions github-actions Bot added the reviewer: ready Automated review found no actionable items label Oct 5, 2026
@github-actions github-actions Bot removed the reviewer: ready Automated review found no actionable items label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Action items

  • [medium] [violation] desktop/README.md:1 - Check: Catalog-only scope (AGENTS.md). Why: This PR adds an unrelated top-level desktop/ folder for a gateway app, which is outside the models/providers catalog. Action: Remove desktop/README.md from this PR.
  • [medium] [possible mistake] providers/sahabatmobile/models/MiniMax-M3.toml:2 - Check: Toggle wire accuracy per AGENTS.md → Reasoning options and audit skill. Why: The file claims thinking.type = "enabled"|"disabled"|"adaptive" for a binary toggle, while the first-party providers/minimax/models/MiniMax-M3.toml is bare toggle with no adaptive state and sibling MiniMax models use []; a third adaptive state contradicts a binary on/off control. Action: Verify against SahabatMobile and upstream MiniMax docs whether adaptive exists and how it maps; correct the comment to the exact forwarded field/values or model the control correctly if it is not binary.
  • [medium] [possible mistake] providers/sahabatmobile/models/mimo-v2.5.toml:1 - Check: Costs are USD/MTok with noted rate/date when converted. Why: PR title advertises QRIS billing (IDR) but headers/prices assert USD/MTok with no conversion rate/date, so it is unverifiable whether 0.15/0.45, 0.30/1.20, 2.00/6.00 are native USD or converted IDR. Action: Confirm billing currency; if converted from IDR, add rate/date to the leading header block, or confirm the docs price natively in USD.
  • [low] [possible mistake] providers/sahabatmobile/models/qwen3.8-max.toml:2 - Check: Relay reasoning baseline must be exposable by this host (lab + peer set, not invented). Why: The triple toggle + effort [low, medium, xhigh] + budget_tokens 0..262144 correctly copies first-party providers/alibaba/models/qwen3.8-max.toml, but the PR provides no SahabatMobile docs/test excerpt proving the gateway forwards enable_thinking / reasoning_effort / thinking_budget (including the claimed non-combinability). Action: Cite SahabatMobile docs or a passthrough test showing which of these three controls are forwarded versus stripped.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Action items

  • [critical] [violation] desktop/main.js:1 - Check: Catalog-only scope per AGENTS.md (models/providers only, nothing else). Why: PR adds full Electron app under desktop/ (README.md, package.json, main.js, preload.js, index.html, renderer.js, styles.css, .gitignore) unrelated to the catalog and unreviewable as model data. Action: Remove the entire desktop/ directory from this PR; submit app code elsewhere.
  • [high] [possible mistake] providers/sahabatmobile/provider.toml:3 - Check: Canonical OpenAI-compatible api base URL. Why: Provider declares https://sahabatmobile.com/api/v1 but added desktop/main.js:582 uses https://www.sahabatmobile.com/api/v1 — one is wrong and clients will misroute. Action: Verify the documented base URL and use the single correct host in provider.toml (and remove desktop/ per above).
  • [medium] [possible mistake] providers/sahabatmobile/models/MiniMax-M3.toml:2 - Check: Toggle wire path must match lab/peer baseline. Why: Comment claims thinking.type = "enabled"|"disabled"|"adaptive" but first-party providers/minimax/models/MiniMax-M3.toml and lab models/minimax/MiniMax-M3.toml support only toggle with no documented adaptive value — extra value needs host evidence. Action: Confirm against SahabatMobile/MiniMax docs whether adaptive is forwarded, or correct comment to enabled|disabled only.
  • [low] [possible mistake] providers/sahabatmobile/provider.toml:4 - Check: env must list only real auth vars. Why: Second entry SAHABAT_API_KEY has no citation in PR body or docs link and looks like an alias/leftover vs canonical SAHABATMOBILE_API_KEY. Action: Keep only the documented key(s) or cite where SAHABAT_API_KEY is specified.
  • [low] [possible mistake] providers/sahabatmobile/models/qwen3.8-max.toml:2 - Check: Relay reasoning_options must be exposed by this host (lab + peer baseline, not invented). Why: toggle + effort [low,medium,xhigh] + budget_tokens 0..262_144 correctly copies first-party providers/alibaba/models/qwen3.8-max.toml, but PR provides no host docs/test that SahabatMobile forwards enable_thinking / reasoning_effort / thinking_budget (same applies to mimo-v2.5/MiniMax-M3 toggles). Action: Provide per-model forwarding evidence (docs snippet or live /chat/completions test showing the fields take effect) or narrow options to what is verified.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Action items

  • [high] [violation] desktop/package.json:1 - Check: Catalog-only contribution scope. Why: PR adds an unrelated Electron app (desktop/README.md, package.json, main.js, preload.js, index.html, renderer.js, styles.css, .gitignore, desktop/build/icon.png) while AGENTS.md is catalog-only for models/ and providers/; unrelated executable code plus a binary cannot be validated by bun validate and expands maintenance/attack surface. Action: Remove all desktop/ files from this PR and keep only the provider catalog.
  • [medium] [possible mistake] providers/sahabatmobile/provider.toml:3 - Check: Canonical API base URL. Why: Provider file uses https://sahabatmobile.com/api/v1 while the PR's own client defaults to https://www.sahabatmobile.com/api/v1; the same PR contradicts itself on apex vs www so one host will fail. Action: Verify the documented base URL and use the single correct host in provider.toml.
  • [medium] [possible mistake] providers/sahabatmobile/models/MiniMax-M3.toml:2 - Check: Toggle wire accuracy for relay. Why: Comment claims thinking.type = "enabled"|"disabled"|"adaptive" for a binary toggle, but first-party providers/minimax/models/MiniMax-M3.toml is toggle-only with no wire doc and no minimax base file documents adaptive; Xiaomi peers use only enabled|disabled, so the third state looks invented. Action: Cite host/upstream docs for adaptive or correct the leading comment to the verified forwarded field/values.
  • [low] [possible mistake] providers/sahabatmobile/models/qwen3.8-max.toml:8 - Check: Direct pricing evidence and tier completeness. Why: All three costs rely on a generic https://sahabatmobile.com/docs citation with no per-model mapping, and the MiniMax relay omits the upstream 512_000 context tier where first-party pricing doubles, so flat retail vs missing tiers cannot be reviewed and long-context cost may be understated. Action: Provide direct per-model pricing references stating what each supports and confirm flat vs tiered retail, adding [[cost.tiers]] if the host tiers.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Action items

  • [high] [violation] providers/sahabatmobile/provider.toml:2 - Check: Every provider must set opencodeai for its default API. Why: AGENTS.md requires opencodeai (npm + api alone leaves v2 sdk.opencodeai empty; the generator does not guess it). This file sets npm + api with no opencodeai. Action: Add opencodeai = "@opencode/ai/providers/openai-compatible" (or the host's own entry if one exists, or "none" with rationale).
  • [medium] [possible mistake] providers/sahabatmobile/models/mimo-v2.5.toml:5 - Check: Do not publish a retired upstream model as active without host availability proof. Why: Base providers/xiaomi/models/mimo-v2.5.toml marks this ID deprecated with live Unsupported model and providers/openrouter/models/xiaomi/mimo-v2.5.toml marks deprecated with expiration; this PR adds the same ID with no status and only a pricing-page citation. Action: Provide live /v1/models or successful-call evidence that SahabatMobile still serves mimo-v2.5, or set status = "deprecated", or drop the file.
  • [medium] [possible mistake] providers/sahabatmobile/models/MiniMax-M3.toml:2 - Check: Toggle wire values must match this host's surface (baseline = lab + same-surface peers). Why: This file claims thinking.type = "enabled"|"disabled" while the first-party providers/minimax/models/MiniMax-M3.toml documents thinking.type = adaptive|disabled; no SahabatMobile docs or probe in the PR proves this relay forwards enabled|disabled. Action: Verify via SahabatMobile docs or live probe which values this host accepts/forwards and correct the header or provide the evidence.
  • [low] [possible mistake] providers/sahabatmobile/models/qwen3.8-max.toml:1 - Check: Costs must be USD/MTok with a direct, mappable source and served-ID evidence. Why: All three files claim USD/MTok from .../dashboard/packages with PR body noting QRIS billing and no conversion rate/date in the header; exact IDs and identical-to-lab prices cannot be reviewed from the PR alone and a URL assertion does not prove the values. Action: Confirm prices are published USD (or add IDR→USD rate/date in the leading header) and provide verifiable evidence the host serves these exact IDs at these prices.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

No actionable findings.

@github-actions github-actions Bot added the reviewer: ready Automated review found no actionable items label Nov 5, 2026
@rekram1-node

Copy link
Copy Markdown
Collaborator

This branch no longer shares history with dev, so it can't be merged as is. Could you rebase onto current dev (or reopen from a fresh branch)? The content passed review.

@sahabatmobile

Copy link
Copy Markdown
Author

Hi @rekram1-node, thanks for the review!

Per your suggestion, I've re-opened this from a fresh branch: #13727 (#13727)

Content is unchanged from this PR (provider entry + MiniMax-M3, mimo-v2.5, qwen3.8-max, logo), revalidated with bun run validate. Merging it results in dev + the 5 provider files only — no workflow files are touched. Feel free to close this one once #13727 is in, or keep whichever is easier for you.

This branch was previously deployed

1 inactive deployment
release — 860ac47c Deployed Nov 15, 2026 by sahabatmobile via review #19037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewer: ready Automated review found no actionable items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants