Repository navigation
fix(tinfoil): accept the auto effort Tinfoil lists for Inkling 2 Small - #13842
Merged
Merged
Conversation
Contributor
Action items
|
Collaborator
Author
|
Good point. auto now maps to the catalog's |
Contributor
Action items
|
Contributor
|
No actionable findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Tinfoil sync started failing today. Tinfoil's /v1/models now lists
autoinsupported_effortsfor inkling-2-small, and the schema only took the catalog's effort levels, so the whole parse threw.autoisn't in Tinfoil's reasoning docs (https://docs.tinfoil.sh/guides/reasoning.md lists the accepted values per model, and Inkling isn't there), and it isn't a catalog level. Renaming it todefaultwould make clients sendreasoning_effort: "default", which Tinfoil doesn't document. So the schema acceptsautoand drops it from the published list. Any other unknown value still fails the sync.Dry run: 0 created, 0 updated, 0 removed, 11 unchanged. Inkling 2 Small has no Tinfoil file today, so nothing published changes. The test covers both the parse and the reasoning_options buildTinfoilModel publishes.