Repository navigation
Conversation
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
No linked issue. Reproduced with the regression tests in this PR.
💡 Background and solution
Sending an initial subscription from
onOpenfails because the hook checks the ready state from the previous React render. The same stale state also lets a send immediately afterdisconnect()silently return, or sends to a replacement socket while it is still connecting.Read the current socket and its native
readyStatewhen sending. Tests cover initial messages fromonOpen, immediate disconnects, and reconnects before the replacement socket opens.Validation:
vitest run src/useWebSocket(8 tests).tsc --noEmitpasses for the hooks package.📝 Changelog
☑️ Self Check before Merge