Repository navigation
refactor(builder): Tag debug variants pairs skipped by minify - #1694
Draft
maxreichmann wants to merge 8 commits into
Draft
maxreichmann wants to merge 8 commits into
maxreichmann wants to merge 8 commits into
Conversation
maxreichmann
commented
Nov 2, 2026
maxreichmann
changed the title
minify
maxreichmann
commented
Nov 3, 2026
maxreichmann
force-pushed
the
fix-dbg-js-mix-in-builds
branch
from
November 3, 2026 16:53
c475a7d to
9df6fa7
Compare
…dbg.js/.js scenarios
If the resource was simply named "..-dbg.js", the `minify` task should process it as normal (because it's a valid case). Only ifthere is a .js sibling, the task should ignore the debug file (covered by other test).
Separate resource discovery from minification eligibility and give existing debug pairs their own cacheable tagging invocations. Preserve warnings for pairs not fully excluded and leave excluded pairs unchanged. Cover cold, warm and delta builds using persistent and in-memory caches, including pair additions and removals.
Pass configured excludes directly to minify and compile ordered path matchers once. Discover all JavaScript resources with one glob so excluded pairs remain visible for tagging. Keep support rules readable by default while preserving explicit re-inclusions. Cover matcher parity with filesystem and memory readers, single-glob enumeration, and support-rule behavior across cold, warm, delta and configuration-change builds.
Supply the global support-file default and prefixed project exclusions from the build definitions. Keep minify generic: match supplied virtual-path patterns without implicit exclusions or path prefixes, preserving ordered re-inclusions and single-glob discovery. Retain the local pattern extraction in defineTask and cover standalone task behavior, normalized definition options, and unchanged cached build results.
matz3
force-pushed
the
fix-dbg-js-mix-in-builds
branch
from
November 4, 2026 16:41
9df6fa7 to
adbba24
Compare
matz3
marked this pull request as draft
November 4, 2026 16:52
Member
|
I've updated the PR to have the minify task tag all relevant resources accordingly, even if they are not minified. It also fixes two general problems that were discovered while working on this. Converted back to draft as I still have to review all changes in-depth and update the title/body. But any comment/feedback is already welcome. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic introduced in #1659, leaves these skipped resource pairs without the
HasDebugVariantandIsDebugVarianttags normally set byminify.Subsequent tasks such as
generateLibraryPreloadrely on these tags and produce incorrect output when they are missing. This change sets the tags for skipped pairs as well.