Repository navigation
Show launcher dialog when ask_to_move is disabled; integrate in place instead - #794
Open
Mouad-Scriptz-0 wants to merge 1 commit into
Open
Mouad-Scriptz-0 wants to merge 1 commit into
Mouad-Scriptz-0 wants to merge 1 commit into
Conversation
ask_to_move=false used to make AppImageLauncher skip the integration
dialog entirely and just run the AppImage without integrating it. This
contradicts how the option is presented in the settings and first run
dialogs ("Ask whether to move AppImage files into the applications
directory", a checkbox inside the "Launcher Dialog" section), and
effectively disables AppImageLauncher's core feature for users who
merely opted out of having their files relocated.
The launcher dialog is now always shown for integrable AppImages. When
the user opted out of moving, the AppImage is integrated in place
(like the daemon already does for watched directories) and the dialog
message no longer claims the file will be moved. The "already
integrated but not in destination directory" prompt is also skipped
in that case, as there is nothing to move.
Mouad-Scriptz-0
marked this pull request as ready for review
October 23, 2026 23:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
ask_to_move = falsein~/.config/appimagelauncher.cfg, AppImageLauncher never shows the integration dialog. The AppImage is silently executed instead, without being integrated:From the user's perspective this looks like AppImageLauncher is completely broken: "the prompt doesn't show up when I double-click a .AppImage file" is exactly how it was reported to me on a Fedora 44/GNOME machine running the 3.0.0-beta full package with
ask_to_move = false. Since the dialog is skipped without any visible feedback, there is no obvious hint that a config option is responsible.Why this is a bug, not intended behavior
The option is presented to users as narrowly controlling the relocation question, nothing else:
src/ui/settings_dialog.ui— group box "Launcher Dialog", checkbox text: "Ask whether to move AppImage files into the applications directory"src/ui/first-run.ui— checkbox text: "Ask me whether to move new AppImages into a central location"A user who unchecks a box inside the "Launcher Dialog" settings section, labeled as being about moving files, does not expect the launcher dialog itself — AppImageLauncher's core feature — to disappear entirely, along with all desktop integration. Neither UI hints that unchecking it disables integration.
Proposed behavior
ask_to_movetrue(unchanged)falseIn-place integration reuses the existing mechanism:
integrateAppImage()already skips the move when source and target paths are identical (the same path the CLI reports as "AppImage already in integration directory"), and it is whatappimagelauncherdeffectively does for AppImages in watched directories, which are registered at their current location today.Changes
src/ui/main.cppask_to_move = falseintegrateAppImage()integrates in placesrc/ui/integration_dialog.{h,cpp}integrateInPlaceconstructor flag; the dialog then shows a message that does not claim the AppImage will be movedNotes for reviewers
ask_to_move = falsebecause it matches the checkbox wording ("move ... into the applications directory" — opting out of the move, not of integration) and the daemon's existing behavior. If the intended semantics were rather "move without asking", thepathToIntegratedAppImagebranch is the single place to flip — feedback welcome.true) is byte-for-byte the previous behavior.ask_to_move = falsesilently skips the dialog (bug), (b) the dialog renders correctly once the early-return is gone, and (c) in-place registration works (the daemon produces such integrations). This patch itself is not compile-tested locally; relying on CI plus a manual test pass before marking ready.Follow-ups (out of scope here)