Repository navigation
Remove dynamic WebAPI interfaces - #1652
Merged
Merged
Conversation
yaakov-h
reviewed
Nov 2, 2026
| [ "appid" ] = "440" | ||
| }; | ||
|
|
||
| KeyValue results = steamNews.Call( "GetNewsForApp", /* version */ 1, newsArgs ); |
Member
There was a problem hiding this comment.
Was this the last usage of .Call in our own code?
| internal readonly string iface; | ||
| internal readonly string apiKey; | ||
|
|
||
| [GeneratedRegex( @"(?<name>[a-zA-Z]+)(?<version>[0-9]*)" )] |
Member
There was a problem hiding this comment.
I don't think WebAPI has to be partial anymore, it was only for this source generator.
| foreach ( var (argName, argValue) in methodArgs ) | ||
| { | ||
| // method is a reserved param for selecting the http request method | ||
| if ( argName.Equals( "method", StringComparison.OrdinalIgnoreCase ) ) |
Member
There was a problem hiding this comment.
"method" used to be a magic key, now it looks like it gets treated like any other arg and shoved in the query string. This will be a breaking change.
Member
Author
There was a problem hiding this comment.
It was only magic in TryInvokeMember.
Member
There was a problem hiding this comment.
so if someone is converting from dynamic they may trip up on this, if they weren't using dynamic then no change.
that's probably just something to call out in the release notes then.
yaakov-h
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
dynamicWebAPI interfacesCloses #1434.
WebAPI.InterfaceandWebAPI.AsyncInterfaceno longer derive fromDynamicObject. UseCall/CallAsync/CallProtobufAsync. Factories are unchanged.List arguments are now flattened to
name[0],name[1]… by the typed calls too (previously dynamic only).If #1651 lands first, this PR will also drop the
DynamicObjectIL3050 suppressions and re-enablePublishAotfor sample 021.Breaking changes
Calls through
dynamicstill compile but throwRuntimeBinderExceptionat runtime.The version suffix becomes the
versionargument, andmethod:becomes the first argument.Usage
About 31 of SteamKit's 918 GitHub dependents call through
dynamic, mostly stale SteamBot forks and small bots. Nearly all pin SteamKit2 1.x or 2.x; only two are on 3.x. Projects that already useCallAsync, such as ArchiSteamFarm, are unaffected.