Skip to content

ValueFilePathCheck improvement for mixed file path - #1005

Merged
babenek merged 2 commits into
Samsung:mainfrom
babenek:file-path-mix
Nov 5, 2026
Merged

babenek merged 2 commits into
Samsung:mainfrom
babenek:file-path-mix

Conversation

@babenek

@babenek babenek commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the change and which is fixed.

  • Bump pandas==3.1.1
  • Improve ValueFilePathCheck

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

Comment thread .github/workflows/check.yml Resolved
@babenek
babenek marked this pull request as ready for review November 5, 2026 10:02
@babenek
babenek requested a review from a team as a code owner November 5, 2026 10:02
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.60%. Comparing base (f89bc6c) to head (115f5fb).

Files with missing lines Patch % Lines
credsweeper/filters/value_file_path_check.py 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1005   +/-   ##
=======================================
  Coverage   90.60%   90.60%           
=======================================
  Files         171      171           
  Lines        7384     7398   +14     
  Branches     1207     1213    +6     
=======================================
+ Hits         6690     6703   +13     
  Misses        469      469           
- Partials      225      226    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@babenek
babenek merged commit 805258b into Samsung:main Nov 5, 2026
27 checks passed
@babenek
babenek deleted the file-path-mix branch November 5, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants