Repository navigation
🐛 Docker build - Keep __tests__ out of the image so next build passes its type check - #2812
Merged
Merged
Conversation
… its type check Since #2783 (next 16.2.4 to 16.4.6), the type check of next build in the Docker build fails with TS2307 on test files that import from scripts/. .dockerignore keeps scripts/ out of the image, so those imports cannot resolve. Staging run 43351607701 of main failed this way after 58 seconds. Tests run in the check workflow, not in the image, so the image does not need __tests__. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UTtNDpWnuaUUQ2winSSgMb
bradystroud
enabled auto-merge (squash)
November 13, 2026 03:15
joshbermanssw
approved these changes
Nov 13, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
✏️
maincannot build an image since #2783. Staging run 43351607701 failed after 58 seconds in the type check ofnext build:Cause: #2783 upgraded
nextfrom 16.2.4 to 16.4.6. The type check of 16.4.6 fails on test files that import fromscripts/, and.dockerignorekeepsscripts/out of the image. Three of the five failing tests are older and passed with 16.2.4 (for example in production run 43338971692 tonight).Fix: add
__tests__to.dockerignore. Tests run in thecheckworkflow, not in the image.Tests
mainwith the Docker file set (scripts excluded as in.dockerignore):tsc --noEmitfails with TS2307 on a test file. The same copy without__tests__: 0 errors.release/v1.8.20(the 06:00 UTC deploy) still has Next 16.2.4./deployon this PR). This fix only removes the first error. Other changes of 16.4 can show up later in the build.Note: #2806 also changes
.dockerignore, a few lines above. The two changes do not overlap.Screenshot (optional)
✏️ Not applicable.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UTtNDpWnuaUUQ2winSSgMb