Skip to content

fix: make RulesChatIndexImageTag parameter required - closes #2786 #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
Closed

fix: make RulesChatIndexImageTag parameter required - closes #2786 #2789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions infra/deploy.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
SSW.Rules.Content branch the Rules Chat index job reads. Default: main.

.PARAMETER RulesChatIndexImageTag
Tag of the rules-chat-index image the index job runs. Default: the same tag as the site image.
Tag of the rules-chat-index image the index job runs. Only the deploy workflow builds and pushes this image.

.PARAMETER RulesChatAlertEmail
Optional email address for index job failure and staleness alerts.
Expand Down Expand Up @@ -87,8 +87,8 @@ param(
[Parameter(Mandatory = $false)]
[string]$RulesChatContentBranch = 'main',

[Parameter(Mandatory = $false)]
[string]$RulesChatIndexImageTag = '',
[Parameter(Mandatory = $true)]
[string]$RulesChatIndexImageTag,

[Parameter(Mandatory = $false)]
[string]$RulesChatAlertEmail = '',
Expand Down Expand Up @@ -456,9 +456,7 @@ $azArgs += '--parameters', "rulesChatFoundryName=$RulesChatFoundryName"
$azArgs += '--parameters', "rulesChatContainerAppsEnvironmentName=$RulesChatContainerAppsEnvironmentName"
$azArgs += '--parameters', "rulesChatIndexJobName=$RulesChatIndexJobName"
$azArgs += '--parameters', "rulesChatContentBranch=$RulesChatContentBranch"
if ($RulesChatIndexImageTag) {
$azArgs += '--parameters', "rulesChatIndexImageTag=$RulesChatIndexImageTag"
}
$azArgs += '--parameters', "rulesChatIndexImageTag=$RulesChatIndexImageTag"
if ($RulesChatAlertEmail) {
$azArgs += '--parameters', "rulesChatAlertEmail=$RulesChatAlertEmail"
}
Expand Down
4 changes: 2 additions & 2 deletions infra/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ param rulesChatContainerAppsEnvironmentName string
@description('Name of the Container Apps job that indexes the rules (32 characters at most)')
param rulesChatIndexJobName string

@description('Tag of the index job image. A tag unique to each build, so the job never runs an older image cached under the same tag.')
param rulesChatIndexImageTag string = imageTag
@description('Tag of the index job image. A tag unique to each build, so the job never runs an older image cached under the same tag. Only the deploy workflow builds and pushes this image.')
param rulesChatIndexImageTag string

@description('SSW.Rules.Content branch the index job reads, matching the content this environment shows')
param rulesChatContentBranch string = 'main'
Expand Down
Loading