Repository navigation
fix: make RulesChatIndexImageTag parameter required - closes #2786 - #2789
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…ment of non-existent image tags - closes #2786 The rulesChatIndexImageTag parameter was optional and defaulted to the site image tag, which could point to an image that was never built or pushed. Only the automated deploy workflow builds and pushes rules-chat-index images. Manual deploy.ps1 runs without this parameter would fail to pull the image. This change makes the parameter required in deploy.ps1 and Bicep, ensuring that manual deployments cannot accidentally set the job to a non-existent image tag. The automated workflow already provides this parameter correctly. Acceptance criteria met: - Manual deploy.ps1 runs cannot set the job to an image tag that does not exist Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 task
Member
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
rulesChatIndexImageTagparameter ininfra/deploy.ps1andinfra/main.bicepwas optional and defaulted to the site'simageTag. When runningdeploy.ps1manually without providing-RulesChatIndexImageTag, the Rules Chat index job would be configured with an image tag that was never built or pushed. Only the automated deploy workflow builds and pushesrules-chat-indeximages, so manual deployments would fail to pull the image, and the failure would only be caught by the 2-day stale alert.Solution
Made the
RulesChatIndexImageTagparameter required in both:infra/deploy.ps1: Changed from optional with empty default to mandatory parameterinfra/main.bicep: Removed the default value that fell back toimageTagThis ensures that:
deploy.ps1runs must explicitly provide the image tagChanges
infra/deploy.ps1:
-RulesChatIndexImageTaga mandatory parameterinfra/main.bicep:
rulesChatIndexImageTagparameterAcceptance Criteria
✅ A manual
deploy.ps1run cannot set the job to an image tag that does not exist (PowerShell will error if the parameter is not provided)