Skip to content

fix: make RulesChatIndexImageTag parameter required - closes #2786 - #2789

Closed
github-actions[bot] wants to merge 1 commit into
mainfrom
fix/rules-chat-index-image-tag-required-7089a3c2064fe55a
Closed

github-actions[bot] wants to merge 1 commit into
mainfrom
fix/rules-chat-index-image-tag-required-7089a3c2064fe55a

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Problem

The rulesChatIndexImageTag parameter in infra/deploy.ps1 and infra/main.bicep was optional and defaulted to the site's imageTag. When running deploy.ps1 manually without providing -RulesChatIndexImageTag, the Rules Chat index job would be configured with an image tag that was never built or pushed. Only the automated deploy workflow builds and pushes rules-chat-index images, so manual deployments would fail to pull the image, and the failure would only be caught by the 2-day stale alert.

Solution

Made the RulesChatIndexImageTag parameter required in both:

  • infra/deploy.ps1: Changed from optional with empty default to mandatory parameter
  • infra/main.bicep: Removed the default value that fell back to imageTag

This ensures that:

  1. Manual deploy.ps1 runs must explicitly provide the image tag
  2. Deployment will fail early with a clear error if the tag is missing, rather than failing later when the job tries to pull a non-existent image
  3. The parameter is always provided (either by the automated workflow or by manual invocation with the correct tag)

Changes

  • infra/deploy.ps1:

    • Made -RulesChatIndexImageTag a mandatory parameter
    • Updated parameter documentation
    • Always pass the parameter to Bicep (removed conditional check)
  • infra/main.bicep:

    • Removed the default value from rulesChatIndexImageTag parameter
    • Updated description to clarify that only the deploy workflow pushes this image

Acceptance Criteria

✅ A manual deploy.ps1 run cannot set the job to an image tag that does not exist (PowerShell will error if the parameter is not provided)

Generated by Issue Triage for issue #2786 · ● 99.1K · ◷

…ment of non-existent image tags - closes #2786

The rulesChatIndexImageTag parameter was optional and defaulted to the site image
tag, which could point to an image that was never built or pushed. Only the
automated deploy workflow builds and pushes rules-chat-index images. Manual
deploy.ps1 runs without this parameter would fail to pull the image.

This change makes the parameter required in deploy.ps1 and Bicep, ensuring
that manual deployments cannot accidentally set the job to a non-existent
image tag. The automated workflow already provides this parameter correctly.

Acceptance criteria met:
- Manual deploy.ps1 runs cannot set the job to an image tag that does not exist

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@AntPolkanov

Copy link
Copy Markdown
Member

Closing in favour of #2791, which fixes #2786 without making the tag mandatory. A mandatory tag would break PR slot deploys, because they pass an empty tag.

This branch was previously deployed

1 inactive deployment
staging — 63fae1e5 Deployed Nov 12, 2026 by AntPolkanov via Delete PR Slot #189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug - Rules chat index job image tag defaults to an image that nobody pushes

1 participant