Repository navigation
chore: change default room version to 11 - #416
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
WalkthroughWhen no room version is configured, ChangesRoom version configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Suggested labels: Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: updating the default room version from 10 to 11. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
🔧 Biome (2.5.14)
-
packages/federation-sdk/src/services/config.service.ts
-
Biome could not lint this file: configuration resulted in errors. Check the repository's Biome configuration and plugins.
-
Warning
Errors were encountered while retrieving linked issues.
Errors: 1
-
- JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/federation-sdk/src/services/config.service.ts">
<violation number="1" location="packages/federation-sdk/src/services/config.service.ts:6">
P1: Changing the default to '11' breaks remote joins to newly created rooms. The make_join handler still advertises only `['10']` (profiles.controller.ts:123), so `ProfilesService.makeJoin` rejects every v11 room with M_INCOMPATIBLE_ROOM_VERSION. Advertise '11' there (e.g. `['10', '11']`) before merging, and check the make_join room_version response as well.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
| import * as z from 'zod'; | ||
|
|
||
| const DEFAULT_ROOM_VERSION: RoomVersion3To11 = '10'; | ||
| const DEFAULT_ROOM_VERSION: RoomVersion3To11 = '11'; |
There was a problem hiding this comment.
P1: Changing the default to '11' breaks remote joins to newly created rooms. The make_join handler still advertises only ['10'] (profiles.controller.ts:123), so ProfilesService.makeJoin rejects every v11 room with M_INCOMPATIBLE_ROOM_VERSION. Advertise '11' there (e.g. ['10', '11']) before merging, and check the make_join room_version response as well.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/federation-sdk/src/services/config.service.ts, line 6:
<comment>Changing the default to '11' breaks remote joins to newly created rooms. The make_join handler still advertises only `['10']` (profiles.controller.ts:123), so `ProfilesService.makeJoin` rejects every v11 room with M_INCOMPATIBLE_ROOM_VERSION. Advertise '11' there (e.g. `['10', '11']`) before merging, and check the make_join room_version response as well.</comment>
<file context>
@@ -3,7 +3,7 @@ import { PersistentEventFactory, type RoomVersion3To11 } from '@rocket.chat/fede
import * as z from 'zod';
-const DEFAULT_ROOM_VERSION: RoomVersion3To11 = '10';
+const DEFAULT_ROOM_VERSION: RoomVersion3To11 = '11';
export interface AppConfig {
</file context>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
+ Coverage 53.51% 53.71% +0.19%
==========================================
Files 113 113
Lines 12706 12706
==========================================
+ Hits 6800 6825 +25
+ Misses 5906 5881 -25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
Summary by CodeRabbit