Repository navigation
Route plugin messages to the in-flight connection while no server is connected - #1907
Open
SendableMetatype wants to merge 1 commit into
Open
SendableMetatype wants to merge 1 commit into
SendableMetatype wants to merge 1 commit into
Conversation
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a player joins or switches servers,
getConnectedServer()returns null untilTransitionSessionHandlersets the new connection. During that time,ClientPlaySessionHandler.handle(PluginMessagePacket)usesgetConnectionInFlight()only for the legacy Forge handshake channel. Messages on every other channel are dropped without a log message.This change uses the fallback for all channels. Forge handshake messages take the same path as before. The existing checks still apply: Velocity discards the message if the backend is not in the PLAY state, and queues it if the connection phases are not complete.
Fixes #1766