Skip to content

Support CUPS 3.x and PAPPL 2.x - #30

Merged
tillkamppeter merged 1 commit into
OpenPrinting:masterfrom
AdeshDeshmukh:modernize-cups3-pappl2
Nov 12, 2026
Merged

tillkamppeter merged 1 commit into
OpenPrinting:masterfrom
AdeshDeshmukh:modernize-cups3-pappl2

Conversation

@AdeshDeshmukh

Copy link
Copy Markdown
Contributor

This pull request brings hplip-printer-app in line with CUPS 3.x and PAPPL 2.x, following the pattern reviewed and approved in OpenPrinting/ps-printer-app#41 and OpenPrinting/ghostscript-printer-app#29.

Summary of Changes:

  1. Makefile Modernization:

    • Prioritizes pkg-config detection for cups3, falling back to cups (CUPS 2.5) and legacy cups-config when available.
    • Adds PAPPL 2.x (pappl2) detection with fallback to pappl.
    • Derives cupsserverbin via pkg-config --variable=prefix when using modern CUPS.
  2. API Alignment (hplip-printer-app.c):

    • Updated cupsArrayNew() calls for spooling_conversions and stream_formats to the 6-argument signature (cupsArrayNew(NULL, NULL, NULL, 0, NULL, NULL)).
    • Retains full backward compatibility with CUPS 2.x while resolving compilation issues under libcups3.

Fixes #29

Copilot AI balanced review requested due to automatic review settings November 12, 2026 05:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@tillkamppeter
tillkamppeter merged commit ecac10d into OpenPrinting:master Nov 12, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support CUPS 3.x and PAPPL 2.x build toolchain

3 participants