Repository navigation
fullhan-opensdk: bump to 8f2079d (GC4653 day file aligned with the SDK's day tunings) - #2911
Conversation
PR Summary by QodoPin openfullhan GC4653 day tuning to 8f2079d
AI Description
Merge Risk
|
Code Review by Qodo
1. A V100 camera day-tuning change ships without target-board tests
|
…K's day tunings) openfullhan 16d7282 gives the GC4653 day file the value every SDK day tuning, and the stock PB1's GC4653 day tuning, has in the word at 0x78 (0x0100); the SDK's GC4633 file it was borrowed from has the night value (0x0040). What the word controls has not been isolated on hardware: the grey V100 day picture in #1610 was majestic's, and its fix ran together with this file. 8f2079d corrects the openfullhan README to say so.
a1fae5b to
90aca26
Compare
|
Thanks. Both points are addressed:
|
Problem
The V100 GC4653 sensor library (#2879) uses the SDK's GC4633 files as its tuning, and the SDK ships the same GC4633 file as both its day and its night tuning. That file has
0x0040in the 16-bit word at0x78. The stock PB1's own GC4653 night tuning has the same value. Every day tuning in the SDK, and the stock PB1's GC4653 day tuning, has0x0100there. So the image'sgc4653_mipi_attr.hexis a night tuning installed as the day one.openfullhan 16d7282 sets that word to
0x0100in the day file only; the night file keeps0x0040. 8f2079d corrects the README there; see below.Boards:
fh8852v100_liteandfh8856v100_lite, the only ones that buildfullhan-opensdk. This is untested on its own: it aligns the day file with the SDK's day tunings, and is not a fix for any symptom measured on hardware.Hardware tested on
The board is
fh8856v100_lite: the PB1 is an FH8856 V100 and runs that image. I have no V100 camera myself. The day file in this pin is the one a PB1 owner (FH8856 V100 + GC4653, board IF56N) has been running since #1610 comment 6969758974. The samesha256is shown below for that file and for this pin. I cannot see that camera; the results below are quoted from the owner's reports.What the hardware does not show is that this word, by itself, changes anything. The all-grey day picture on that camera turned out to come from majestic on every FH885x V100. A majestic test build fixed it, and that build ran with this day file. The old value has not been tried with the fixed majestic. 16d7282's commit message blames the old value for the grey picture. That is wrong, and 8f2079d corrects the README to say what is and is not known. The case for this bump is that the day file now matches every SDK day tuning and the stock camera's own day tuning, not a measured difference.
Evidence
Pinned tarball, checked against the file the owner installed:
Before, with the current pin's day file and the current majestic: the owner's daylight snapshot had
R = G = Bin all 3,686,400 pixels (#1610).After, with this day file (owner, #1610 comment 6972138565:
Day file is 2dd5a...) and the majestic V100 test build (comment 7027991564): "Colour is quite good", and 2,745,630 of the 3,686,400 pixels of the 2560x1440 snapshot are not grey. Since majestic also changed between those runs, this does not isolate the word at0x78; see above.Scope
general/package/all-patches/linux/(those go to OpenIPC/linux)general/overlay/or in a sharedload_<vendor>script hardcodes a value specific to my boardLD_PRELOAD, and no binaries that cannot be rebuilt from source