Repository navigation
Conversation
Without a configured Wi-Fi device the script brought up eth0 unconditionally. A Wi-Fi-only board has no eth0, and ifup then failed with an error at every boot. Check for the interface first and say that there is nothing to bring up otherwise.
PR Summary by QodoSkip eth0 bring-up when no Ethernet interface exists
AI Description
Merge Risk
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR |
openipc-ai
left a comment
There was a problem hiding this comment.
Reproduced on the qemu-bench twin (hi3516ev300, release rootfs, eth0 renamed away before S40network, no wlandev):
master: Starting network...
ip: SIOCGIFINDEX: No such device
PR: Starting network...
No wlandev and no eth0: nothing to bring up
With eth0 present, nothing changes: udhcpc: lease of 10.0.2.15 on both. The image built from this branch, booted on the fh8626v100 twin (where the GMAC doesn't probe), prints the same new line. test_network_failover.sh passes.
Problem
When no Wi-Fi device is configured, S40network brought up
eth0unconditionally. A board without Ethernet has noeth0, so every boot printed an error from theeth0interface setup instead of a statement of what happened.The change brings
eth0up only when/sys/class/net/eth0exists and otherwise says there is nothing to bring up. Boards with Ethernet, and every Wi-Fi path, are unchanged.Hardware tested on
FH8626V100, Tenda CP3 V2.2 (Wi-Fi only, no Ethernet), RAM-loaded OpenIPC image, booted with no Wi-Fi device configured.
Evidence
Before (boot log):
After:
Scope
general/package/all-patches/linux/(those go to OpenIPC/linux)general/overlay/or in a sharedload_<vendor>script hardcodes a value specific to my boardLD_PRELOAD, and no binaries that cannot be rebuilt from sourceOrigin
This work adds support needed for the Tenda CP3 V2.2 based on the Fullhan FH8626V100. The implementation was developed with Claude assisting the reverse-engineering analysis of the official Tenda firmware and was repeatedly validated on a physical CP3 V2.2. Reverse-engineering was performed with REA and by direct analysis of the official device firmware and its observable hardware behaviour.
The Fullhan media SDK was not available during this work and was never used. No proprietary Tenda/Fullhan firmware images, binaries, SDK material, disassemblies, boot-ROM dumps or extracted vendor blobs are included in this contribution. The implementation is independently authored from the observed behaviour, public/open-source code and hardware testing.
I am submitting the work so the implementation and hardware findings are available to the OpenIPC community for review, testing and further development. I hope it is a useful base for others working with FH8626V100 hardware, and the community is very welcome to refine and carry it forward.