[koki-star]

Description

Fixes #1093

Author:

• @koki-star

This replaces the seven remaining window.confirm calls with OED's existing ConfirmActionModalComponent. The changes cover group area calculations, group child compatibility warnings, meter displayable warnings, map deletion, and large raw-data exports.

The existing confirmation behavior, toast notifications, permissions, size checks, and download logic are preserved. The confirmation messages and buttons were also updated and translated where needed.

Testing completed:

• Manually tested the Cancel and confirmation actions
• npm run check
• Docker test suite: 942 passing, 0 failing, and 1 pending

Type of change

• Note merging this changes the database configuration.
• This change requires a documentation update

Checklist

• I have followed the [OED pull request](https://openenergydashboard.org/developer/pr/) ideas
• I have removed text in ( ) from the issue request
• You acknowledge that every person contributing to this work has signed the [OED Contributing License Agreement](https://openenergydashboard.org/developer/cla/) and each author is listed in the Description section.

Limitations

None.

Screenshots

I tested all seven confirmation popups. Click each one to view the screenshot.

1. Create Group area

2. Edit Group area

3. Group compatibility warning

4. Meter display warning

5. Delete Map

6. Export size warning

7. Admin export limit

[huss]

@koki-star First, I am sorry this review took so long (see Discord msg on the OED server in developer channel).

Thank you for your first contribution to OED. I appreciate you figuring out how to do this across different uses in OED. Review and testing found it works as desired. I have made a few comments to consider. Some are questions that may not need any changes. Please let me know if anything is not clear or you have thoughts/questions.

[huss]

@koki-star I am sweeping open items and wanted to ask you the status of this work. Thanks.

[koki-star]

@huss Sorry for the slow reply. I pushed a new commit that covers your four comments: the translations, the meter displayable state, the export comments, and the useEffect explanation. I tested it locally. The meter displayable warning works with Cancel and Continue, a change with no warning saves right away, and the raw export confirm works with Cancel and Continue. To see the export modal I set the warning file size to 0 for the test, then set it back. Let me know if anything else needs to change.

[huss]

@koki-star Thank you for the updated code that addressed all my comments. To be safe, I locally merged in development and did a final test where no issues were found. Congratulations on your first accepted contribution to OED.

[koki-star]

Thanks a lot @huss I learned a lot from your comments on this one. I really appreciate the review and I'm glad it got merged.

[huss]

@koki-star It was a pleasure to have you work on OED. If you want to do anything else then simply let OED know.