Repository navigation
Add documentation for genuine check - #643
Merged
Merged
Conversation
Contributor
Author
|
I'll update them after my university work today |
jans23
reviewed
Nov 5, 2026
jans23
left a comment
Member
There was a problem hiding this comment.
Overall try to make it shorter. Also avoid questions as subtitles.
robin-nitrokey
requested changes
Nov 6, 2026
robin-nitrokey
left a comment
Member
There was a problem hiding this comment.
The text now only uses the term “authenticity” but the page is still called “genuine”/“Genuine Verification”. We should use consistent terms here.
daringer
requested changes
Nov 10, 2026
| ----------------------------------- | ||
|
|
||
| Nitrokeys are provisioned with model-specific attestation keys. These attestation keys can only be provisioned by Nitrokey. If the firmware of the keys are tampered with, this attestation certificate will not be available anymore. The Nitrokey user applications like pynitrokey and Nitrokey App 2 offers a mechanism to cryptographically validate these certificates to ensure the firmware was not tampered with or the device was not replaced with a malicious, non-Nitrokey device. | ||
| Nitrokeys are provisioned with model-specific attestation keys. These attestation keys can only be provisioned by Nitrokey. The Nitrokey user applications like pynitrokey and Nitrokey App 2 offers a mechanism to cryptographically validate these certificates to ensure the device was not replaced with a malicious, non-Nitrokey device. |
Contributor
There was a problem hiding this comment.
"like pynitrokey and Nitrokey App 2 offers" -> "like pynitrokey and Nitrokey App 2 offer"
|
|
||
| Connect the Nitrokey and run ``nitropy nk3 test`` or ``nitropy nkpk test`` for Nitrokey 3 or Nitrokey Passkey respectively. The FIDO2 test includes the verification test. If the key passes the test, it would imply the key is authentic. | ||
|
|
||
| .. code-block:: shell-session |
Contributor
There was a problem hiding this comment.
think this shouldn't be intended - otherwise it will be a blockquote
AdityaMitra5102
force-pushed
the
genuine-verif
branch
from
November 10, 2026 17:54
c7a3dc6 to
265d3dd
Compare
robin-nitrokey
approved these changes
Nov 10, 2026
Member
|
@AdityaMitra5102 Please check the CI failures. |
Contributor
Author
|
Could you pls run the CI once more |
Member
|
@daringer Please review again to unblock the merge. |
daringer
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.