Skip to content

Phase 5: Add favorites, account dashboard and discovery features - #5

Merged
Nirmalsiddh merged 1 commit into
mainfrom
feat/phase5-portfolio-features
Oct 23, 2026
Merged

Nirmalsiddh merged 1 commit into
mainfrom
feat/phase5-portfolio-features

Conversation

@Nirmalsiddh

Copy link
Copy Markdown
Owner

Summary

Adds Phase 5 portfolio functionality to HavenHub:

  • Save/remove favorites and browse paginated Saved Listings.
  • Owner-scoped My Listings dashboard.
  • Private account profile with listing and saved counts.
  • Bounded discovery pagination and allowlisted sorting.
  • Consistent live review averages and counts on cards and details.

Architecture and security

  • Separate favorites collection with a unique user/listing index.
  • Account and ownership queries derive identity from the authenticated session.
  • Mutations remain CSRF-protected; duplicate favorites and missing listings are handled.
  • Ratings use a shared raw MongoDB aggregation accepting valid scalar numeric values from 1–5, excluding malformed stored strings/booleans.
  • Query projections, bounds, and indexes support discovery and account pages.

Verification

  • Complete disposable MongoDB suite: 132 passed, 0 failed, 0 skipped.
  • Focused portfolio tests: 23 passed.
  • Targeted Chromium rating checks: 12 passed at mobile and desktop widths, with no observed JS errors or CSP violations.
  • Database-free suite: 74 passed; 2 database suites intentionally skipped.
  • Dependency audit: zero reported vulnerabilities.
  • git diff --check: passed.
  • Disposable test databases verified empty after cleanup; no production data or Cloudinary assets accessed.

Known limitations / deployment prerequisites

  • Favorite cleanup across collections is best effort; ambiguous failures may leave invisible orphan references.
  • Review additive index rollout against existing data before deployment.
  • Large-dataset and deep-pagination performance are not yet verified.
  • Real Cloudinary/CDN/TLS, other browsers/devices, and manual screen-reader tests remain unverified.

Deployment is not included. Please wait for both GitHub Actions jobs to pass before merging.

@Nirmalsiddh
Nirmalsiddh merged commit 83b5309 into main Oct 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant