Skip to content

iOS: a controller with no gyroscope leaves the phone's gyro in charge (#971) - #1365

Merged
LNPANDY merged 1 commit into
mainfrom
fix/971-ios-phone-gyro-fallback
Nov 15, 2026
Merged

LNPANDY merged 1 commit into
mainfrom
fix/971-ios-phone-gyro-fallback

Conversation

@LNPANDY

@LNPANDY LNPANDY commented Nov 15, 2026

Copy link
Copy Markdown
Owner

Fix or feature

  • Fix
  • Feature

What and why

Fixes #971 (rebases and renumbers #975 onto main after #1281 and #1361).

Problem. On iOS, a controller that advertises a gyroscope it does not have (such as the GameSir X5 Lite) sends constant non-zero motion reports and suppresses the phone's built-in gyro.
Cause. dm_motion_attach treated any report that was not all zeroes as live motion.
Change. Carry @Haseenesss's two patches from #975 renumbered to 0057 (forwarded seedds/nxnative#1877) and 0058 (fork-only test priming update) so a controller becomes a motion source only after rotationRate changes from its first report.

Checks and patch details
  • patches/0057-motion-a-controller-is-a-source-once-its-rotatio.patch (Upstream-Status: forwarded seedds/nxnative#1877)
  • patches/0058-test-native-controller-motion-primes-the-adapter.patch (Upstream-Status: fork-only)
  • python3 tools/engine.py check passed (55 patches apply cleanly to 94a0944755da)
  • Zero-history shallow git am -3 of all 55 patches onto 94a0944755da passed
  • python3 -m unittest discover tools/tests passed (266 tests, 35 skipped, 0 failures)
  • git diff --check passed

Checked

  • Tests: python3 tools/engine.py check, zero-history git am -3, and python3 -m unittest discover tools/tests (266 tests, 35 skipped)
  • Test for a fix: dm/host/tests/t_motion_apple.m and dm/host/tests/t_controllers_mac.m (delegated to GitHub Actions macOS CI)
  • Run on a device or Mac: Not run locally (cloud Linux environment)

Screenshots

None, no visible change.

Scope

  • No engine file (dm/, scripts/, docs/, ref/) is added to the repository: a change there is a patch in patches/ (a commit in engine/, then tools/engine.py export, and tools/engine.py check passes), with its Upstream-Status
  • A fix to the engine or a game profile also goes to seedds/nxnative as a PR in parallel: this PR's patch says forwarded seedds/nxnative#..., or pending until that PR is open
  • A change to a launcher view has before and after screenshots above
  • No keys, game files or data extracted from a game in the change or the attachments

Rebase PR #975 onto main (upstream pin 94a0944755da) and renumber its two patches to 0057 and 0058 after #1281 and #1361.

Co-authored-by: Haseenesss <Haseenesss@gmail.com>
@LNPANDY LNPANDY added bug Something isn't working patch-queue Changes the patch queue or the upstream pin labels Nov 15, 2026
@LNPANDY
LNPANDY merged commit 3739300 into main Nov 15, 2026
18 checks passed
@LNPANDY
LNPANDY deleted the fix/971-ios-phone-gyro-fallback branch November 15, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch-queue Changes the patch queue or the upstream pin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1.3.0 game builds stopped recognising gyros/motion

1 participant