Skip to content

discoveryengine: add google_discovery_engine_project_provision resource - #19873

Merged
SirGitsalot merged 2 commits into
GoogleCloudPlatform:mainfrom
SirGitsalot:discovery-engine-project-provision
Oct 30, 2026
Merged

SirGitsalot merged 2 commits into
GoogleCloudPlatform:mainfrom
SirGitsalot:discovery-engine-project-provision

Conversation

@SirGitsalot

Copy link
Copy Markdown
Member

Add the GA google_discovery_engine_project_provision create-only resource for Discovery Engine's projects.locations.provision API (ProjectService.ProvisionProject), supporting optional data-use terms consent (accept_data_use_terms, data_use_terms_version), optional saas_params (is_biz, accept_biz_qos), and regionalized location (defaulting to "global"), along with isolated ephemeral-project acceptance tests.

b/579558678

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_discovery_engine_project_provision`

Adds the GA google_discovery_engine_project_provision create-only resource for Discovery Engine ProjectService.ProvisionProject (b/579558678).

```release-note:new-resource
`google_discovery_engine_project_provision`
```
@modular-magician

modular-magician commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2a7a5f9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 768 insertions(+)
google-beta provider View Diff 4 files changed, 768 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
57 51 3 3
Affected Service Packages
  • discoveryengine

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDiscoveryEngineProjectProvision_discoveryengineProjectProvisionBasicExample
  • TestAccDiscoveryEngineProjectProvision_discoveryengineProjectProvisionFullExample
  • TestAccDiscoveryEngineProjectProvision_discoveryengineProjectProvisionSaasParamsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Findings Test Name
❌ Error · Log - TestAccDiscoveryEngineProjectProvision_discoveryengineProjectProvisionBasicExample
❌ Error · Log - TestAccDiscoveryEngineProjectProvision_discoveryengineProjectProvisionFullExample
❌ Error · Log - TestAccDiscoveryEngineProjectProvision_discoveryengineProjectProvisionSaasParamsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@SirGitsalot VCR tests complete for 2a7a5f9!

@modular-magician

modular-magician commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4e9533e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 768 insertions(+)
google-beta provider View Diff 4 files changed, 768 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
57 51 3 3
Affected Service Packages
  • discoveryengine

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDiscoveryEngineProjectProvision_discoveryengineProjectProvisionBasicExample
  • TestAccDiscoveryEngineProjectProvision_discoveryengineProjectProvisionFullExample
  • TestAccDiscoveryEngineProjectProvision_discoveryengineProjectProvisionSaasParamsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Findings Test Name
✅ Log - TestAccDiscoveryEngineProjectProvision_discoveryengineProjectProvisionBasicExample
✅ Log - TestAccDiscoveryEngineProjectProvision_discoveryengineProjectProvisionFullExample
✅ Log - TestAccDiscoveryEngineProjectProvision_discoveryengineProjectProvisionSaasParamsExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@SirGitsalot VCR tests complete for 4e9533e!

@SirGitsalot

Copy link
Copy Markdown
Member Author

@modular-magician reassign-reviewer

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from c2thorn October 30, 2026 03:09

@c2thorn c2thorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine for a create-only resource

@SirGitsalot
SirGitsalot added this pull request to the merge queue Oct 30, 2026
Merged via the queue into GoogleCloudPlatform:main with commit e4b2583 Oct 30, 2026
35 checks passed
@SirGitsalot
SirGitsalot deleted the discovery-engine-project-provision branch October 30, 2026 18:44
@modular-magician modular-magician added the type/new-resource Adds a brand new Terraform resource label Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants