Repository navigation
discoveryengine: add google_discovery_engine_project_provision resource - #19873
SirGitsalot merged 2 commits into
Conversation
Adds the GA google_discovery_engine_project_provision create-only resource for Discovery Engine ProjectService.ProvisionProject (b/579558678). ```release-note:new-resource `google_discovery_engine_project_provision` ```
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2a7a5f9: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @SirGitsalot VCR tests complete for 2a7a5f9! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4e9533e: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @SirGitsalot VCR tests complete for 4e9533e! |
|
@modular-magician reassign-reviewer |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
c2thorn
left a comment
There was a problem hiding this comment.
looks fine for a create-only resource
e4b2583
Add the GA
google_discovery_engine_project_provisioncreate-only resource for Discovery Engine'sprojects.locations.provisionAPI (ProjectService.ProvisionProject), supporting optional data-use terms consent (accept_data_use_terms,data_use_terms_version), optionalsaas_params(is_biz,accept_biz_qos), and regionalizedlocation(defaulting to"global"), along with isolated ephemeral-project acceptance tests.b/579558678
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.