Repository navigation
networkconnectivity: add interconnect_key_group resource - #19795
amanMahendroo wants to merge 1 commit into
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4924baf: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_connectivity_interconnect_key_group" "primary" {
interconnects {
interconnect = # value needed
}
}
Unreadable test reportMissing test detection may be incomplete because the following tests can't be read. Each test step's
Test reportImportant Manual Verification Required VCR cannot automatically execute the following tests added in this PR. Please verify them manually: 🔴 TestAccNetworkConnectivityInterconnectKeyGroup_update Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @amanMahendroo VCR tests complete for 4924baf! |
4924baf to
64f4362
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 64f4362: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @amanMahendroo VCR tests complete for 64f4362! |
64f4362 to
457dc94
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 457dc94: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode Skipped RECORDING mode because a newer commit (68b18f4) was pushed to the PR. |
457dc94 to
68b18f4
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 68b18f4: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @amanMahendroo VCR tests complete for 68b18f4! |
Adds the beta-only
google_network_connectivity_interconnect_key_groupresource: a regional group of customer-provided MACsec keys (CKN/CAK) that Cloud Interconnect connections can use for MACsec ("bring your own key").keys.cak_wois write-only (Terraform 1.11+), so the CAK is never stored in state or plan files. The API never returns it either.keys.<name>update-mask path, so existing CAKs are never re-sent. In-place changes tostart_timeorcknare rejected at plan time.keysis a list (write-only attributes can't be in sets). Reordering keys is not a diff.interconnects(output) lists the names of the Interconnects that use the key group.Draft for initial review. Manually tested against prod (create, import, reorder, cak-only change, rejected in-place change, key rotation, PSK -> key group migration with the follow-up PR). The acceptance tests need the
IKG_PREVIEWvisibility label on the CI projects; that request is in progress. Rotating keys on a key group attached to a Z2Z (test) Interconnect isn't supported by the API yet; that support is rolling out separately. The acceptance test doesn't add keys after creation (a new key's start time must be at least 6 hours in the future, which VCR can't replay); that path was verified manually.Part of b/482272248
Fixes b/568177309