Repository navigation
Quantum: Remove the unused job --storage option and legacy SDK storage support - #10541
Draft
v-elegacheva wants to merge 4 commits into
Draft
v-elegacheva wants to merge 4 commits into
v-elegacheva wants to merge 4 commits into
Conversation
Save CLI and vendored SDK removal, regression tests, and migration guidance. New changes have not been tested.
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution v-elegacheva! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
added
Auto-Assign
v-elegacheva
changed the title
Keep workspace creation changes owned by PR Azure#10478 and preserve the standalone job storage removal. Rename the shared command-parser test helper to reflect its workspace and job usage.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change removing per-job storage overrides in favor of workspace-linked storage.
No open issues 🎉
What changed in this PR
Removes the unused per-job --storage option and legacy storage overrides from the Quantum extension’s vendored SDK, keeping jobs on workspace-linked storage.
Changes:
- Removes
--storagefrom job commands and adds migration errors that do not echo its value. - Removes SDK storage connection-string overrides and obsolete container helpers.
- Adds regression tests, updates migration documentation and help, and bumps the version to
1.0.0b32.
| File | Description |
|---|---|
src/quantum/setup.py |
Bumps the extension version to 1.0.0b32. |
src/quantum/README.rst |
Documents option removal and migration guidance. |
src/quantum/HISTORY.rst |
Records the breaking change and SDK cleanup. |
src/quantum/azext_quantum/vendored_sdks/azure_quantum_python/workspace.py |
Removes storage overrides and uses linked storage exclusively. |
src/quantum/azext_quantum/vendored_sdks/azure_quantum_python/storage.py |
Removes obsolete connection-string container helpers. |
src/quantum/azext_quantum/tests/latest/test_quantum_workspace.py |
Tests SDK argument rejection and linked-storage behavior. |
src/quantum/azext_quantum/tests/latest/test_quantum_jobs.py |
Tests parsing, safe rejection, help, and job submission. |
src/quantum/azext_quantum/operations/job.py |
Removes storage parameters and forwards optional arguments by keyword. |
src/quantum/azext_quantum/_params.py |
Removes job storage argument registration. |
src/quantum/azext_quantum/_help.py |
Clarifies workspace-linked storage behavior. |
src/quantum/azext_quantum/__init__.py |
Adds a pre-parse guard for removed storage options. |
Review effort: Balanced
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove storage connection-string overrides from the Quantum CLI and its vendored SDK.
Changes