Skip to content

feat(core): allow_unreachable also fails ticks of unreachable services and actions - #25

Merged
robin-mueller merged 1 commit into
masterfrom
feat/allow-unreachable-failure
Nov 16, 2026
Merged

robin-mueller merged 1 commit into
masterfrom
feat/allow-unreachable-failure

Conversation

@robin-mueller

Copy link
Copy Markdown
Member

With allow_unreachable set, the default onFailure() of RosServiceNode and RosActionNode now returns FAILURE (with a throttled warning) on an unreachable or timed-out service/server instead of throwing. Previously only creating the client tolerated this, so an outage at tick time terminated the whole executor. Behavior without the option is unchanged. Adds unit tests (test/unit/ros_service_node.cpp) and updates the option docs.

🤖 Generated with Claude Code

…s and actions

With allow_unreachable set, the default onFailure() of RosServiceNode and
RosActionNode returns FAILURE (with a throttled warning) for an unreachable
server or a request that is not answered in time, instead of throwing a
RosNodeError that ends the tree. Without the option nothing changes.

A tree that talks to a server that comes and goes (e.g. a controller manager
that is busy or restarting) can then react to the failure in a Fallback.
Unit tests of RosServiceNode: an unreachable service throws by default and
fails with allow_unreachable.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@robin-mueller
robin-mueller merged commit 840d554 into master Nov 16, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant