Repository navigation
feat(core): allow_unreachable also fails ticks of unreachable services and actions - #25
Merged
Merged
Conversation
…s and actions With allow_unreachable set, the default onFailure() of RosServiceNode and RosActionNode returns FAILURE (with a throttled warning) for an unreachable server or a request that is not answered in time, instead of throwing a RosNodeError that ends the tree. Without the option nothing changes. A tree that talks to a server that comes and goes (e.g. a controller manager that is busy or restarting) can then react to the failure in a Fallback. Unit tests of RosServiceNode: an unreachable service throws by default and fails with allow_unreachable. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
allow_unreachableset, the defaultonFailure()ofRosServiceNodeandRosActionNodenow returns FAILURE (with a throttled warning) on an unreachable or timed-out service/server instead of throwing. Previously only creating the client tolerated this, so an outage at tick time terminated the whole executor. Behavior without the option is unchanged. Adds unit tests (test/unit/ros_service_node.cpp) and updates the option docs.🤖 Generated with Claude Code