Repository navigation
[0.87] fix(ios): backport clear text background omission for IME underlines - #59445
kurohune538 wants to merge 1 commit into
Conversation
|
Hi @kurohune538! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
Backport the production fix from #59207 to
0.87-stableand add five regression tests, following the 0.88 backport in #59432.The default clear
NSBackgroundColorAttributeNamesuppresses the Japanese IME composition underline even while the native marked range remains active. Omitting that no-op attribute restores the underline. Visible backgrounds and foreground/background opacity remain intact.This is intentionally limited to the underline root cause. It does not change TextInput delegates, selection/synchronization logic, or claim to solve every CJK composition issue discussed in #56082.
Production fix by Gregory Moskaliuk (@hryhoriiK97); regression coverage adapted from the 0.88 backport by @riottt.
Related to #48497 and the underline portion of #56082.
Changelog:
[IOS] [FIXED] - Avoid a default transparent text background that can suppress the Japanese IME composition underline.
Test Plan:
RCT_USE_PREBUILT_RNCORE=0 bundle exec pod install --no-repo-update.RCTAttributedTextUtilsTest.mminRNTesterUnitTestsfor verification; that project-only edit is excluded from this PR.RCTAttributedTextUtilsTeston an iPhone 17 Pro / iOS 26.5 simulator. The 0.87 branch has an unrelated compile failure inRCTTurboModuleArrayBufferTests.mm, so that source was excluded from this targeted run.git diff --checkpasses.