Repository navigation
Register selectable paragraphs in the iOS component factory - #59367
Closed
christophpurrer wants to merge 1 commit into
Closed
christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
Summary: Selectable text resolves to a distinct paragraph component when prepared text layout is enabled. iOS did not register that component, so it mounted an unimplemented view. Register a private paragraph subclass with the selectable descriptor and reuse the existing text drawing, selection, accessibility, layout and event implementation. Changelog: [iOS][Fixed] - Render selectable text when prepared text layout is enabled Differential Revision: D126837680
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126837680. |
Collaborator
|
This pull request was successfully merged by Abhishek Kumar in 0999156 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 0999156. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Selectable text resolves to a distinct paragraph component when prepared text layout is enabled. iOS did not register that component, so it mounted an unimplemented view. Register a private paragraph subclass with the selectable descriptor and reuse the existing text drawing, selection, accessibility, layout and event implementation.
Changelog:
[iOS][Fixed] - Render selectable text when prepared text layout is enabled
Differential Revision: D126837680