Repository navigation
recipes: libsecp256k1: name the extrakeys and schnorrsig modules explicitly - #3402
Merged
T-Dynamos merged 1 commit intoOct 27, 2026
Merged
Conversation
This is a no-op today: both modules have defaulted to yes in every secp256k1 release since 0.2.0. It only makes the dependency explicit, the way --enable-module-recovery already is, whose default is no. The dependency is real. coincurve links against the library this recipe installs rather than its own vendored copy, because its patch stubs out download_library() and _find_lib(), and its cffi build then includes secp256k1_extrakeys.h and secp256k1_schnorrsig.h unconditionally. secp256k1 installs those headers only for the modules that are enabled. Upstreamed from https://github.com/spesmilo/python-for-android
f321x
changed the title
|
coverage: 63.297%. remained the same — f321x:202610_libsecp256k1_schnorr_modules into kivy:develop |
T-Dynamos
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a no-op today: both modules have defaulted to yes in every secp256k1 release since 0.2.0. It only makes the dependency explicit, the way --enable-module-recovery already is, whose default is no.
The dependency is real though. coincurve links against the library this recipe installs rather instead of its own vendored copy, because its patch stubs out download_library() and _find_lib(), and its cffi build then includes secp256k1_extrakeys.h and secp256k1_schnorrsig.h unconditionally.
secp256k1 installs those headers only for the modules that are enabled.
Upstreamed from https://github.com/spesmilo/python-for-android