Skip to content

Revert "fix: drop the internal UT-2026-0115 su pseudo-terminal patch" - #28

Merged
Zeno-sole merged 1 commit into
masterfrom
revert-27-drop-ut-2026-0115-patch
Oct 28, 2026
Merged

Zeno-sole merged 1 commit into
masterfrom
revert-27-drop-ut-2026-0115-patch

Conversation

@Zeno-sole

@Zeno-sole Zeno-sole commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Reverts #27

Summary by Sourcery

Restore the su pseudo-terminal handling patch removed by the previous change.

Bug Fixes:

  • Restore the internal UT-2026-0115 su pseudo-terminal patch.

Chores:

  • Revert the previous removal of the su pseudo-terminal patch and update Debian patch metadata accordingly.

@sourcery-ai

sourcery-ai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Reverts the prior removal of the internal UT-2026-0115 su pseudo-terminal patch by restoring its 38-line implementation, enabling it through the Debian patch series, and documenting the change in the package changelog.

File-Level Changes

Change Details Files
Reintroduce the internal UT-2026-0115 pseudo-terminal handling patch for su.
  • Add the patch implementation under Debian packaging patches.
  • Register the patch in the Debian quilt series file.
debian/patches/UT-2026-0115-su-tiocsti.patch
debian/patches/series
Record the reversal in the package changelog.
  • Add a changelog entry documenting the revert.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
deepin-ci-robot requested a review from myml October 28, 2026 01:27
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zeno-sole. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown

TAG Bot

TAG: 2.40.4-3deepin16
EXISTED: yes
DISTRIBUTION: unstable

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@Zeno-sole
Zeno-sole merged commit 0591854 into master Oct 28, 2026
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants