Cyrilic shortcuts do not work for main menu

[YevgenBorodkin]

Hello,
I noticed that shortcuts do not work for Cyrillic symbols, but I assume it should be applicable to non-Latin symbols in general.
I did not check if different keyboard layouts (like Dvorak) are also impacted, I want to think that it is handled on a system level, and we get the expected key code.

Here are the steps to reproduce when File menu is not opened.
I want to open "&File" menu, it is localized as "&Файл", but on the keyboard letter "Ф" is located where letter "A" is.
I am using correct keyboard layout in the system and press Latin "A" to open a file menu as it is really "Ф".
But nothing happens.

Internally, the system sees this scan code as "A", what I assume is expected, but the mapping is not there.
GetToolBarCtrl().MapAccelerator(key, &uId) returns 0, and we do not get into "if" condition.

  const TCHAR key = static_cast<TCHAR>(pMsg->wParam);
  const bool alnum = (key >= '0' && key <= '9') || (key >= 'A' && key <= 'Z');
  if ((pMsg->message == WM_SYSKEYDOWN) && alnum && GetToolBarCtrl().MapAccelerator(key, &uId) != 0)
  {
  	ShowKeyboardCues(true);
  	OnMenuBarMenuItem(uId);
  	return TRUE;
  }

MenuBar.cpp line 404

Interesting that with Cyrillic translation enabled, but with English layout, pressing ALT+F does not open "&Файл" menu.

Seems we need to remap accelerator keys, but I am not an expert in MFC.
Do you know what is the best fix for it? Do you see similar issues in other languages?

[sdottaka]

I could not verify this with a Cyrillic keyboard myself, but I have attempted a fix in the following commit by handling menu accelerators via WM_SYSCHAR instead of WM_SYSKEYDOWN:

5caa405